Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between routing values in bodies versus query string #626

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 18, 2024

Description

Differentiate between routing values in bodies versus query string

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia added the skip-changelog No need to update CHANGELOG. label Oct 18, 2024
Copy link
Contributor

Changes Analysis

Commit SHA: 9d6dd77
Comparing To SHA: d2733fe

API Changes

Summary

└─┬Components
  ├──[➕] schemas (31481:7)
  └─┬_common:Routing
    ├──[➕] type (31479:13)❌ 
    ├──[➖] oneOf (31480:11)❌ 
    └──[➖] oneOf (31481:11)❌ 

Document Element Total Changes Breaking Changes
components 4 3
  • BREAKING Changes: 3 out of 4
  • Removals: 2
  • Additions: 2
  • Breaking Removals: 2
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11396646594/artifacts/2072223121

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 29 29 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
504 317 (62.9 %)

@dblock dblock merged commit 7855eca into opensearch-project:main Oct 18, 2024
27 checks passed
@Xtansia Xtansia deleted the fix/differentiate-routing-types branch October 20, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants