Setting #621

brunoLloret · 2024-10-17T17:05:12Z

Description

Removed extra docker-compose file
Removed script_language and shard_store tests due to API unfamiliarity
Fixed DCO by amending commit with -s flag
Rebased and squashed commits for easier DCO fix
Ran linter with npm run lint --fix
Ensured all remaining tests pass

Note to reviewers:

DCO has been fixed
Commits have been squashed
Linter has been run
All current tests are passing
Remaining tests were already in tests/default directory (?)
I will explore more the API to move ahead with more substantial tests, any hints or further indications are welcomed!

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

brunoLloret · 2024-10-17T17:06:33Z

I will sign off the unsigned commit and resubmit

* Allow shortcut specifying InlineScript as just a string Signed-off-by: Thomas Farr <[email protected]> * Add test Signed-off-by: Thomas Farr <[email protected]> * Allow arbitrary script language Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

Signed-off-by: dblock <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

* fix spec snapshot endpoint Signed-off-by: Tatsuya Kawakami <[email protected]> * fix lint and add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

* update with accurate numeric type for common, core Signed-off-by: amberzsy <[email protected]> * add changelog Signed-off-by: amberzsy <[email protected]> * update explian value field with 'General Number' Signed-off-by: amberzsy <[email protected]> --------- Signed-off-by: amberzsy <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

- Added tests for core endpoints: _refresh, _remote/info, _script_context - Added test for indices endpoint: _template - Removed tests for _script_language and _shard_stores due to API unfamiliarity - Cleaned up local environment files Signed-off-by: Bruno Lloret <[email protected]>

plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore Add local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>

…rity Signed-off-by: Bruno Lloret <[email protected]>

* fix snapshot restore and recovery endpoint Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Fixed index naming, description and changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

* Edit msearch parameters descriptions Signed-off-by: Archer <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore BAdd local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>

Signed-off-by: Bruno Lloret <[email protected]>

… script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml Signed-off-by: Bruno Lloret <[email protected]>

Signed-off-by: Bruno Lloret <[email protected]>

github-actions · 2024-10-18T12:12:54Z

Changes Analysis

Commit SHA: 3461acc
Comparing To SHA: d2733fe

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11394540575/artifacts/2073931629

API Coverage

	Before	After	Δ
Covered (%)	588 (57.59 %)	588 (57.59 %)	0 (0 %)
Uncovered (%)	433 (42.41 %)	433 (42.41 %)	0 (0 %)
Unknown	29	29	0

dblock

Looks like a test failed, an API was likely introduced later than 1.3.7 and a test needs a version: >= ... tag. Make sure to confirm it's the case.

ERROR   _core/script_language.yaml (tests/default/_core/script_language.yaml)
    ERROR   CHAPTERS
        ERROR   Retrieve information about available script languages.
            PASSED  REQUEST BODY
            ERROR   RESPONSE STATUS (Expected status 200, but received 500: application/json. Internal Server Error)
            SKIPPED RESPONSE PAYLOAD BODY
            SKIPPED RESPONSE PAYLOAD SCHEMA
            SKIPPED RESPONSE OUTPUT VALUES

I think you should make this PR just about the new tests and remove all the setup/package.json and related changes.

There's a lot of commits in this PR for what ends up being a small change, you should squash them into 1 commit in this PR to clean things up and make git history easier to read.

dblock · 2024-10-18T12:12:17Z

package.json

+  },
+  "devDependencies": {
+    "dotenv": "^16.4.5",
+    "eslint-plugin-yaml": "^1.0.3"


This seems out of place. This project doesn't release a JavaScript library, so move these into dependencies to be consistent.

tests/default/_core/refresh.yaml

dblock · 2024-10-18T12:15:08Z

.cspell

@@ -84,6 +84,7 @@ lucene
 Lucene
 lycheeverse
 marvinpinto
+memlock


Are those used anywhere?

they were on my local docker-compose.yaml, got it!

dblock · 2024-10-18T12:15:29Z

.gitignore

-
-# coverage output
-/coverage/
-


Was this accidentally deleted? We want this.

dblock · 2024-10-18T12:15:44Z

eslint.config.mjs

@@ -118,6 +118,7 @@ export default [
    },
    rules: {
      'yml/no-empty-document': 'off',
+      'yml/no-empty-mapping-value': 'off',


Why is this needed?

linter was complaining when I left a value empty in one of the basic tests I was writing, I will delete it though and make sure it makes sense for future tests

Signed-off-by: Bruno Lloret <[email protected]>

Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

Signed-off-by: Bruno Lloret <[email protected]>

brunoLloret force-pushed the setting branch 2 times, most recently from 2b15005 to e0de9ea Compare October 17, 2024 17:44

Xtansia and others added 16 commits October 17, 2024 16:14

Fix: specify _source includes/excludes. (#607)

133c1f2

Signed-off-by: dblock <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

Added tests for the notifications plugin. (#594)

8feaa22

Signed-off-by: dblock <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

enmeded, removed shard_store and script_language due to API unfamilia…

f7a0803

…rity Signed-off-by: Bruno Lloret <[email protected]>

integration docker yaml with remote repo fetched

78b2069

Signed-off-by: Bruno Lloret <[email protected]>

integration docker yaml with remote repo fetched

40a4ec8

Signed-off-by: Bruno Lloret <[email protected]>

plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml,…

0641501

… script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml Signed-off-by: Bruno Lloret <[email protected]>

gitignore

32a3f72

Signed-off-by: Bruno Lloret <[email protected]>

Remove .env from tracking and add it to .gitignore

401049f

Signed-off-by: Bruno Lloret <[email protected]>

brunoLloret force-pushed the setting branch from 4a52fe7 to 401049f Compare October 17, 2024 23:15

brunoLloret added 3 commits October 17, 2024 16:16

Delete docker-compose.yml

5fa89a9

Signed-off-by: Bruno Lloret <[email protected]>

Delete .gitignore

09c4e8c

Signed-off-by: Bruno Lloret <[email protected]>

Merge branch 'opensearch-project:main' into setting

3461acc

dblock requested changes Oct 18, 2024

View reviewed changes

brunoLloret and others added 4 commits October 18, 2024 08:20

Delete .cspell

b581ccb

Signed-off-by: Bruno Lloret <[email protected]>

Delete package.json

c2f4fc3

Signed-off-by: Bruno Lloret <[email protected]>

Update tests/default/_core/refresh.yaml

9db5b36

Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>

Delete eslint.config.mjs

c965381

Signed-off-by: Bruno Lloret <[email protected]>

brunoLloret closed this Oct 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting #621

Setting #621

brunoLloret commented Oct 17, 2024

brunoLloret commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

dblock left a comment

dblock Oct 18, 2024

dblock Oct 18, 2024

brunoLloret Oct 18, 2024

dblock Oct 18, 2024

dblock Oct 18, 2024

brunoLloret Oct 18, 2024

Setting #621

Setting #621

Conversation

brunoLloret commented Oct 17, 2024

Description

Issues Resolved

brunoLloret commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

Changes Analysis

API Changes

Summary

Report

API Coverage

dblock left a comment

Choose a reason for hiding this comment

dblock Oct 18, 2024

Choose a reason for hiding this comment

dblock Oct 18, 2024

Choose a reason for hiding this comment

brunoLloret Oct 18, 2024

Choose a reason for hiding this comment

dblock Oct 18, 2024

Choose a reason for hiding this comment

dblock Oct 18, 2024

Choose a reason for hiding this comment

brunoLloret Oct 18, 2024

Choose a reason for hiding this comment