Add basic GET tests for core and indices endpoints #616
Conversation
… script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml
Settings + GETs
There was a problem hiding this comment.
This is great, thanks for filling some of these out!
- Get rid of the extra docker compose, is Dashboards needed for these tests? We should probably think about introducing that separately, and otherwise it should go into
tests/default. - Fix DCO,
git commit --amend -s. - Rebase/squash your commits, will be easier to fix 1 commit for DCO.
- Fix linter,
npm run lint--fix, possibly more. - Make sure all tests pass.
- Mark this as ready, let's merge it.
docker-compose.yml
Outdated
| @@ -0,0 +1,69 @@ | |||
| --- | |||
There was a problem hiding this comment.
Delete this file, if you need a custom docker-compose it should be under tests/xyz.
.gitignore
Outdated
| @@ -19,3 +19,4 @@ build/ | |||
| # coverage output | |||
| /coverage/ | |||
|
|
|||
| .env | |||
There was a problem hiding this comment.
Do you use a .env file with a tool? Maybe something we can recommend in dev guide for env variables?
There was a problem hiding this comment.
I used it for setting my local environment and perhaps it does not make sense to add it for the remote repo's codebase. I think it can be removed for the remote repo although if you think it's good to document for the guidelines I can do it. Lmk!
There was a problem hiding this comment.
I think it's definitely useful as a dev setup. We set environment variables all the time and this could be the recommended way of doing so. Make a separate PR for this change though and update the developer guide to use the dotenv setup.
Changes AnalysisCommit SHA: 43674a1 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11372053324/artifacts/2065266855 API Coverage
|
plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore BAdd local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
integration docker yaml with remote repo fetched
plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore BAdd local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>
…rity Signed-off-by: Bruno Lloret <[email protected]>
Merge/update
Signed-off-by: Bruno Lloret <[email protected]>
Merging setting->main
|
@brunoLloret lmk if you need help, I'm dblock on the OpenSearch public slack (https://opensearch.org/slack.html) |
- Added tests for core endpoints: _refresh, _remote/info, _script_context - Added test for indices endpoint: _template - Removed tests for _script_language and _shard_stores due to API unfamiliarity - Cleaned up local environment files Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Add basic GET tests for core and indices endpoints
Hey! I tried to join the OpenSearch public Slack using the link you provided (https://opensearch.org/slack.html), but it says the link is no longer active. Do you know if there's an updated link or another way to join the Slack workspace? |
Uh oh, @krisfreedain? |
|
Thanks for letting us know! I'll work to get it resolved ASAP |
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Delete docker-compose.yml
Signed-off-by: Bruno Lloret <[email protected]>
* Allow shortcut specifying InlineScript as just a string Signed-off-by: Thomas Farr <[email protected]> * Add test Signed-off-by: Thomas Farr <[email protected]> * Allow arbitrary script language Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: dblock <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: dblock <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
* fix spec snapshot endpoint Signed-off-by: Tatsuya Kawakami <[email protected]> * fix lint and add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
* update with accurate numeric type for common, core Signed-off-by: amberzsy <[email protected]> * add changelog Signed-off-by: amberzsy <[email protected]> * update explian value field with 'General Number' Signed-off-by: amberzsy <[email protected]> --------- Signed-off-by: amberzsy <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
- Added tests for core endpoints: _refresh, _remote/info, _script_context - Added test for indices endpoint: _template - Removed tests for _script_language and _shard_stores due to API unfamiliarity - Cleaned up local environment files Signed-off-by: Bruno Lloret <[email protected]>
plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore Add local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>
…rity Signed-off-by: Bruno Lloret <[email protected]>
* fix snapshot restore and recovery endpoint Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Fixed index naming, description and changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
* Edit msearch parameters descriptions Signed-off-by: Archer <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Bruno Lloret <[email protected]>
plain GETs for ./tests/default/_core/ refresh.yaml, remote_info.yaml, script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml gitignore Remove .env from tracking and add it to .gitignore BAdd local Docker Compose file to .gitignore Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
… script_context.yaml, and script_language.yaml; for ./tests/default/indices/ shard_stores.yaml, and template.yaml Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off in all previous commits resolved. .env and docker-compose.yml removed.
Signed-off-by: Bruno Lloret <[email protected]>
Signed-off-by: Bruno Lloret <[email protected]>
Description
Set of basic GET tests for various core and indices endpoints:
Added tests for core endpoints: _refresh, _remote/info, _script_context, and _script_language
Added tests for indices endpoints: _shard_stores and _template
Updated docker-compose.yml to include OpenSearch and OpenSearch Dashboards services
Minor updates to package.json and .gitignore
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.