Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove knn from search request body #580

Merged

Conversation

amberzsy
Copy link
Contributor

@amberzsy amberzsy commented Sep 15, 2024

Description

remove knn from search request body

Issues Resolved

Closes #579 .

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: amberzsy <[email protected]>
Copy link
Contributor

Changes Analysis

Commit SHA: dbff9dc
Comparing To SHA: c2c666f

API Changes

Summary

└─┬Paths
  ├─┬/_search
  │ ├─┬GET
  │ │ └─┬Requestbody
  │ │   └─┬application/json
  │ │     └─┬Schema
  │ │       └──[➖] properties (25350:15)❌ 
  │ └─┬POST
  │   └─┬Requestbody
  │     └─┬application/json
  │       └─┬Schema
  │         └──[➖] properties (25350:15)❌ 
  └─┬/{index}/_search
    ├─┬GET
    │ └─┬Requestbody
    │   └─┬application/json
    │     └─┬Schema
    │       └──[➖] properties (25350:15)❌ 
    └─┬POST
      └─┬Requestbody
        └─┬application/json
          └─┬Schema
            └──[➖] properties (25350:15)❌ 

Document Element Total Changes Breaking Changes
paths 4 4
  • BREAKING Changes: 4 out of 4
  • Removals: 4
  • Breaking Removals: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10875048347/artifacts/1935961084

API Coverage

Before After Δ
Covered (%) 560 (54.85 %) 560 (54.85 %) 0 (0 %)
Uncovered (%) 461 (45.15 %) 461 (45.15 %) 0 (0 %)
Unknown 25 25 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
585 290 (49.57 %)

@dblock dblock merged commit de28026 into opensearch-project:main Sep 16, 2024
18 checks passed
dblock pushed a commit to dblock/opensearch-api-specification that referenced this pull request Sep 23, 2024
* remove knn from search request body

Signed-off-by: amberzsy <[email protected]>

* add CHANGELOG

Signed-off-by: amberzsy <[email protected]>

---------

Signed-off-by: amberzsy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KNN should not be part of request body
2 participants