Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes NeuralQuery Schema #512

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Fixes NeuralQuery Schema #512

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f51d8e
Fixes NeuralQuery Schema
uriofferup Aug 14, 2024
ec13056
Remove unsupported validation
uriofferup Aug 14, 2024
a3921b7
Adds encoding base64
uriofferup Aug 14, 2024
2477d15
Add CHANGELOG
uriofferup Aug 14, 2024
24b1787
Adding Test Case
uriofferup Aug 16, 2024
1e38f88
Adding Tests and Error Responses to Schema
uriofferup Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/schemas/_common.query_dsl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,6 @@ components:
type: string
query_image:
type: string
format: binary
dblock marked this conversation as resolved.
Show resolved Hide resolved
model_id:
type: string
k:
Expand All @@ -1248,8 +1247,9 @@ components:
type: number
filter:
$ref: '#/components/schemas/QueryContainer'
required:
- model_id
Copy link
Member

@dblock dblock Aug 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is model ID not required? AFAIK it is. What's a valid query without a model ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per documentation, it is required if the default model id is not set. Here is explained how to configure it.

anyOf:
urinud marked this conversation as resolved.
Show resolved Hide resolved
- required: query_text
- required: query_image
ParentIdQuery:
allOf:
- $ref: '#/components/schemas/QueryBase'
Expand Down
Loading