-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ML neural search. #504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
August 13, 2024 14:38
Changes AnalysisCommit SHA: 392a0b6 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10371987146/artifacts/1807014485 API Coverage
|
Spec Test Coverage Analysis
|
dblock
force-pushed
the
neural-search
branch
2 times, most recently
from
August 13, 2024 14:43
783a5ae
to
8909bfe
Compare
Signed-off-by: dblock <[email protected]>
nhtruong
reviewed
Aug 13, 2024
@@ -59,6 +59,7 @@ gsub | |||
Gsub | |||
haasephonetik | |||
heteroscedastic | |||
hnsw | |||
homoscedastic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've learned a big word today 😄
nhtruong
approved these changes
Aug 13, 2024
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes end-to-end flow for neural search.
Added
/_plugins/_ml/models/{model_id}/_deploy
,_undeploy
andknn_vector
type topassage_embedding
.Issues Resolved
Closes #315.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.