Fix: semver comparisons for ranges. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Changes AnalysisCommit SHA: 935704b API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10372517526/artifacts/1807173651 API Coverage
|
dblock
force-pushed
the
fix-semver
branch
2 times, most recently
from
b23f7d3 to
2742683
Compare
Spec Test Coverage Analysis
|
Xtansia
reviewed
Aug 12, 2024
Signed-off-by: dblock <[email protected]>
Xtansia
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes semver comparisons for ranges, using the default that the library supports (without ruby-style commas).
Raises an error when semver range is incorrectly specified (hence the new utils helpers).
Re-enables tests/default/ingest/pipeline.yaml that passes with the current 3.0.
Issues Resolved
Closes #500.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.