Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indices.stats schemas #491

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Aug 12, 2024

Description

Improve indices.stats schemas

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia marked this pull request as ready for review August 12, 2024 05:06
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Changes Analysis

Commit SHA: 99cfcf9
Comparing To SHA: 00711ea

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_stats
│ │ └─┬GET
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └─┬_all
│ │             └──[🔀] $ref (43638:13)❌ 
│ ├─┬/_stats/{metric}
│ │ └─┬GET
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └─┬_all
│ │             └──[🔀] $ref (43638:13)❌ 
│ ├─┬/_stats
│ │ └─┬GET
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └─┬_all
│ │             └──[🔀] $ref (43638:13)❌ 
│ └─┬/{index}/_stats/{metric}
│   └─┬GET
│     └─┬Responses
│       └─┬200
│         └─┬application/json
│           └─┬Schema
│             └─┬_all
│               └──[🔀] $ref (43638:13)❌ 
└─┬Components
  ├──[➖] schemas (43673:7)❌ 
  ├──[➖] schemas (43738:7)❌ 
  ├──[➖] schemas (43949:7)❌ 
  ├──[➖] schemas (43892:7)❌ 
  ├──[➖] schemas (43815:7)❌ 
  ├──[➖] schemas (26456:7)❌ 
  ├──[➕] schemas (43648:7)
  ├──[➕] schemas (43638:7)
  ├──[➕] schemas (43667:7)
  ├─┬indices.stats:IndicesStats
  │ ├──[➕] required (43719:11)❌ 
  │ ├──[➕] required (43717:11)❌ 
  │ ├──[➕] required (43718:11)❌ 
  │ ├──[➖] properties (43733:9)❌ 
  │ ├──[➖] properties (43735:9)❌ 
  │ └─┬shards
  │   └─┬Schema
  │     └─┬Schema
  │       └──[🔀] $ref (43649:9)❌ 
  ├─┬nodes._common:Stats
  │ └─┬indices
  │   └──[🔀] $ref (43649:9)❌ 
  ├─┬_common:StoreStats
  │ ├──[➖] properties (28207:9)❌ 
  │ └──[➖] properties (28209:9)❌ 
  ├─┬_common:IndexingStats
  │ ├──[➖] properties (27032:9)❌ 
  │ └─┬types
  │   └─┬Extensions
  │     └──[➕] x-version-removed (27002:30)
  └─┬indices.stats:IndexStats
    ├──[➖] type (43678:13)❌ 
    ├──[➖] properties (43714:9)❌ 
    ├──[➖] properties (43680:9)❌ 
    ├──[➖] properties (43682:9)❌ 
    ├──[➖] properties (43684:9)❌ 
    ├──[➖] properties (43686:9)❌ 
    ├──[➖] properties (43688:9)❌ 
    ├──[➖] properties (43690:9)❌ 
    ├──[➖] properties (43692:9)❌ 
    ├──[➖] properties (43694:9)❌ 
    ├──[➖] properties (43696:9)❌ 
    ├──[➖] properties (43698:9)❌ 
    ├──[➖] properties (43700:9)❌ 
    ├──[➖] properties (43702:9)❌ 
    ├──[➖] properties (43704:9)❌ 
    ├──[➖] properties (43706:9)❌ 
    ├──[➖] properties (43716:9)❌ 
    ├──[➖] properties (43708:9)❌ 
    ├──[➖] properties (43710:9)❌ 
    ├──[➖] properties (43712:9)❌ 
    ├──[➕] allOf (43665:11)
    └──[➕] allOf (43667:7)

Document Element Total Changes Breaking Changes
components 42 36
paths 4 4
  • BREAKING Changes: 40 out of 46
  • Modifications: 6
  • Removals: 31
  • Additions: 9
  • Breaking Removals: 31
  • Breaking Modifications: 6
  • Breaking Additions: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10346236327/artifacts/1800306216

API Coverage

Before After Δ
Covered (%) 510 (49.95 %) 510 (49.95 %) 0 (0 %)
Uncovered (%) 511 (50.05 %) 511 (50.05 %) 0 (0 %)
Unknown 24 24 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
534 117 (21.91 %)

Signed-off-by: Thomas Farr <[email protected]>
@dblock dblock merged commit 597ed8d into opensearch-project:main Aug 12, 2024
15 checks passed
@Xtansia Xtansia deleted the feat/indices-stats branch August 12, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants