-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the missing item types for security API related schemas #420
Updates the missing item types for security API related schemas #420
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
Changes AnalysisCommit SHA: ec97b6b API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9998424218/artifacts/1716894606 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test please into tests
and update CHANGELOG?
Are all the schemas for these items the same? Should this be a $ref
?
@dblock I have a work-in-progress item for tests. I'll raise a separate PR to add tests for all security related APIs. |
We want to avoid regressions, so maybe PR the tests first? Either way this PR should be rebased and pass existing tests. |
i'll mark this as draft meanwhile. |
Closing this as changes will be covered by #439 |
Description
This PR updates missing
items
property for parent properties ofarray
type in the security schema.Issues Resolved
security
namespace #233 (comment)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.