Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate response content types #394

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Validate response content types #394

merged 5 commits into from
Jul 10, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Jul 10, 2024 •
edited
Loading

Description

Validate response content types

Issues Resolved

Fixes #392

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia added the skip-changelog No need to update CHANGELOG. label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Changes Analysis

Commit SHA: 673a0e6
Comparing To SHA: 046b7d1

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9881799396/artifacts/1688516948

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@Xtansia Xtansia marked this pull request as draft July 10, 2024 02:04
Xtansia added 2 commits July 10, 2024 14:06
@Xtansia
Correct cat health test
b0bb1d6 
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia
Correct passed test fixture
9a4d63f 
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia marked this pull request as ready for review July 10, 2024 03:27
dblock
dblock requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Add a test fixture into invalid_data.yml (or a new fixture, might be worth reorganizing those files a little to split by different error type like request/response/invalid) that tests both possible new failures in integration tests.

@Xtansia Xtansia force-pushed the feat/validate_response_content_type branch from 2f5d2a0 to 673a0e6 Compare July 10, 2024 21:34
@Xtansia Xtansia requested a review from dblock July 10, 2024 22:01
@dblock dblock merged commit 45953f0 into opensearch-project:main Jul 10, 2024
10 checks passed
@Xtansia Xtansia deleted the feat/validate_response_content_type branch July 10, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

Assignees
No one assigned
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Response content-type in spec tests is not validated
2 participants
@Xtansia @dblock