[WIP] Add test node #377
[WIP] Add test node #377
Conversation
Signed-off-by: Bzil <[email protected]>
Signed-off-by: Bzil <[email protected]>
| @@ -268,6 +268,21 @@ paths: | |||
| responses: | |||
| '200': | |||
| $ref: '#/components/responses/nodes.info@200' | |||
| /_nodes/{metric}/stats: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This path already exists in the spec, it is /_nodes/{node_id}/stats and is part of the nodes.stats operation not nodes.info
Changes AnalysisCommit SHA: a37033c API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9808029450/artifacts/1671078058 API Coverage
|
Signed-off-by: Bzil <[email protected]>
| method: GET | ||
| parameters: | ||
| metric: | ||
| - data:true |
There was a problem hiding this comment.
@dblock do you have any idea how to implement a fix for this test ?
There was a problem hiding this comment.
This error?
FAILED Nodes _cluster_manager metric with a json response.
FAILED PARAMETERS
FAILED metric (data/0 must be equal to one of the allowed values)
The data:true value doesn't seem like a valid metric.
There was a problem hiding this comment.
it's seems weird yes, but it's define in documentation
There was a problem hiding this comment.
Is it read like a JSON value? Quote it, "data:true"?
There was a problem hiding this comment.
if I do that, that implies that I have to put it in the enum and therefore do I have to do the same for data:false and the other filters?
There was a problem hiding this comment.
I suppose that yes? There's really no such thing as booleans in URL paths AFAIK, this is a very creative use of the API.
There was a problem hiding this comment.
These should be using /_nodes/{node_id}/stats
| @@ -268,6 +268,21 @@ paths: | |||
| responses: | |||
| '200': | |||
| $ref: '#/components/responses/nodes.info@200' | |||
| /_nodes/{metric}/stats: | |||
There was a problem hiding this comment.
This path already exists in the spec, it is /_nodes/{node_id}/stats and is part of the nodes.stats operation not nodes.info
| - _all | ||
| - _cluster_manager |
There was a problem hiding this comment.
These are node filters not metric names
| nodes: | ||
| type: object | ||
| additionalProperties: | ||
| $ref: '#/components/schemas/NodeInfo' | ||
| oneOf: | ||
| - type: object | ||
| $ref: '#/components/schemas/NodeInfo' | ||
| - type: object | ||
| additionalProperties: {} | ||
| _nodes: | ||
| $ref: 'nodes._common.yaml#/components/schemas/NodesResponseBase' | ||
| required: | ||
| - cluster_name | ||
| - nodes | ||
| - _nodes |
There was a problem hiding this comment.
These changes are likely due to the duplicate path and having the wrong schemas, please revert them and test again with other changes made.
| @@ -7,3 +7,53 @@ chapters: | |||
| method: GET | |||
There was a problem hiding this comment.
This file should be moved under tests/nodes/ and split into info.yaml and stats.yaml
| method: GET | ||
| parameters: | ||
| metric: | ||
| - data:true |
There was a problem hiding this comment.
These should be using /_nodes/{node_id}/stats
| response: | ||
| status: 200 | ||
| - synopsis: Nodes _all metric with a json response. | ||
| path: /_nodes/{metric} |
There was a problem hiding this comment.
This one is technically /_nodes/{node_id}
|
Last tests from this PR made it into #455. |
TODO
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.