Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for search with seq_no_primary_term #367

Merged

Conversation

emtammaru
Copy link
Contributor

Description

Add test spec for search with the seq_no_primary_term param as suggested by @dblock here: opensearch-project/opensearch-go#574 (comment)

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Erik Tammaru <[email protected]>
@dblock
Copy link
Member

dblock commented Jun 28, 2024

Thanks! Would love more test coverage around _search schema if you have time.

@dblock dblock merged commit bb63d76 into opensearch-project:main Jun 28, 2024
5 checks passed
Copy link
Contributor

Changes Analysis

Commit SHA: 97c2186
Comparing To SHA: 73d5524

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9715044137/artifacts/1649468031

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock
Copy link
Member

dblock commented Jun 28, 2024

Looks like GHA was delayed so the tests didn't run on this PR. Will monitor.

https://www.githubstatus.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants