-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for application/yaml response payloads. #363
Conversation
Changes AnalysisCommit SHA: 2128acc API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9716543764/artifacts/1649566586 API Coverage
|
2b2cf3f
to
5e25965
Compare
@@ -29,13 +29,13 @@ components: | |||
type: string | |||
docs.count: | |||
description: available docs | |||
oneOf: | |||
anyOf: | |||
- type: string | |||
- nullable: true | |||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably scope creeping but nullable
is not a proper JSON schema keyword. Even if it was, this is redundant because nullable string already encapsulates non-nullable string.
In this case and a few below, we can repalce anyOf: ...
with type: [string, null]
according to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but it failed with some other error. Care to open an issue with some details to replace?
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: Theo Nam Truong <[email protected]>
This is stuck at "Checking for ability to merge automatically…" |
Description
On top of #360, Added application/yaml support and responses to cat APIs. This one requires deserializing the response body into an object to validate.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.