Test framework/guide #359
Test framework/guide #359
Conversation
nhtruong
force-pushed
the
test_framework/guide
branch
from
a493867 to
89f31e1
Compare
nhtruong
requested review from
dblock,
harshavamsi,
sachetalva,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Changes AnalysisCommit SHA: c8aaf54 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9666746566/artifacts/1637069617 API Coverage
|
| import { SchemaVisitor } from './utils/SpecificationVisitor' | ||
| import { is_ref, type MaybeRef, SpecificationContext } from './utils' | ||
| import { SchemaVisitor } from '../_utils/SpecificationVisitor' | ||
| import { is_ref, type MaybeRef, SpecificationContext } from '../_utils' |
There was a problem hiding this comment.
What's the reason for the leading underscore on _utils?
There was a problem hiding this comment.
To differentiate it from other folders like tester linter merger where they are tools while _utils is not a tool.
tools/src/tester/test.ts
Outdated
| } from '../OpenSearchHttpClient' | ||
| import ChapterReader from './ChapterReader' | ||
| import ChapterEvaluator from './ChapterEvaluator' | ||
| import OperationLocator from './OperationLocator' | ||
| import SchemaValidator from './SchemaValidator' | ||
| import StoryEvaluator from './StoryEvaluator' | ||
| import { ConsoleResultLogger } from './ResultLogger' | ||
| import {ConsoleResultLogger} from './ResultLogger' |
There was a problem hiding this comment.
I'm surprised the linter isn't complaining about this as it should be enforcing spacing around the braces (or at least it was)
There was a problem hiding this comment.
I setup my IDE to run --fix on save. I thought the linter wanted space too.
There was a problem hiding this comment.
This looks suspicious. Other files have a space. We definitely want 1 rule for spaces before/after {} - Something is off with the eslint rule file being used?
There was a problem hiding this comment.
Fixed it. Didn't dig too deep but object-curly-spacing rule was deprecated in ESLint v8.53.0 and moved to a different plugin. Installing the plugin and enabled that rule solved it.
- Reduced noise when running spec tests - `--verbose` now provides better context for non-2XX responses. - Moved `linter/utils` to `_utils` because it's also being used by the tester tool (To avoid misleading stacktrace when an error appears in utils) Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
test_framework/guide
branch
from
dde1822 to
0547647
Compare
tools/src/tester/test.ts
Outdated
| } from '../OpenSearchHttpClient' | ||
| import ChapterReader from './ChapterReader' | ||
| import ChapterEvaluator from './ChapterEvaluator' | ||
| import OperationLocator from './OperationLocator' | ||
| import SchemaValidator from './SchemaValidator' | ||
| import StoryEvaluator from './StoryEvaluator' | ||
| import { ConsoleResultLogger } from './ResultLogger' | ||
| import {ConsoleResultLogger} from './ResultLogger' |
There was a problem hiding this comment.
This looks suspicious. Other files have a space. We definitely want 1 rule for spaces before/after {} - Something is off with the eslint rule file being used?
Signed-off-by: Theo Truong <[email protected]>
--verbosenow provides better context for non-2XX responses.linter/utilsto_utilsbecause it's also being used by the tester tool (To avoid misleading stacktrace when an error appears in utils)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.