Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade TypeScript version to remove eslint warning. #346

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 19, 2024

Description

Currently you see

> eslint . --report-unused-disable-directives

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.4.5

Please only submit bug reports when using the officially supported version.

=============

I wasn't able to find a set of compatible libraries that upgrade eslint, but downgrading by one seems harmless.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jun 19, 2024
Copy link
Contributor

Changes Analysis

Commit SHA: d0e28a5
Comparing To SHA: 16bcb63

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9582661711/artifacts/1617099657

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@nhtruong nhtruong merged commit cffb404 into opensearch-project:main Jun 19, 2024
8 of 16 checks passed
@dblock dblock deleted the remove-eslint-warning branch June 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants