Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted ChapterOutput.create_dummy_from_output. #340

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 12, 2024

Description

This is a super nit that I've neen OCD-ing over ;)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jun 12, 2024
Signed-off-by: dblock <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Changes Analysis

Commit SHA: e9df980
Comparing To SHA: 6601633

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9487923176/artifacts/1595115707

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (6601633) to head (e9df980).

Files Patch % Lines
tools/src/tester/ChapterOutput.ts 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   79.83%   79.80%   -0.03%     
==========================================
  Files          45       45              
  Lines        1369     1367       -2     
  Branches      279      279              
==========================================
- Hits         1093     1091       -2     
  Misses        276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nhtruong nhtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is a super nit that I've neen OCD-ing over ;) "neen" -> "been" :P

@nhtruong nhtruong merged commit 49cd814 into opensearch-project:main Jun 12, 2024
10 checks passed
@dblock dblock deleted the misc-output branch June 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants