Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollups API spec #283

Merged
merged 5 commits into from
May 13, 2024
Merged

Rollups API spec #283

merged 5 commits into from
May 13, 2024

Conversation

djmadeira
Copy link
Contributor

Description

Add specs for rollup APIs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock
dblock previously requested changes May 7, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please sign DCO, git commit -s --amend.

package-lock.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

API specs implemented for 274/649 (42%) APIs.

@djmadeira djmadeira force-pushed the rollups branch 5 times, most recently from e2d5943 to 101afef Compare May 7, 2024 13:41
@djmadeira
Copy link
Contributor Author

@dblock done

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

API specs implemented for 274/649 (42%) APIs.

@dblock
Copy link
Member

dblock commented May 8, 2024

@dblock done

DCO is still failing, see the error message above, I think it has to match the name

@djmadeira
Add rollup API spec
5f3e4fa 
Signed-off-by: djmadeira <[email protected]>
@djmadeira
Copy link
Contributor Author

@dblock looks like it's passing now

@dblock
Copy link
Member

dblock commented May 8, 2024

@nhtruong or @Xtansia take a look at the spec?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

API specs implemented for 274/649 (42%) APIs.

@nhtruong
Copy link
Collaborator

nhtruong commented May 9, 2024 •
edited
Loading

This is great, Thanks @djmadeira
Regarding the x-operation-group, instead of rollups.get_rollup, rollups.delete_rollup... we should use rollups.get, rollups.delete... instead to avoid repeating the world rollup as all of these actions are in the rollups namespace. We have a similar naming convention in the indices namespace with indices.create, indices.delete and so on.

@djmadeira djmadeira requested review from Tokesh and aabeshov as code owners May 13, 2024 15:33
@djmadeira
rename operation groups
9c4cde4 
Signed-off-by: djmadeira <[email protected]>
@djmadeira
Copy link
Contributor Author

@nhtruong addressed feedback

@nhtruong
Copy link
Collaborator

@djmadeira looks like some x-operation-group haven't not been updated. And there are 2 transforms.get@200 entries and they caused some workflows to fail.

@djmadeira
remove file from other PR
2b72a86 
Signed-off-by: djmadeira <[email protected]>
djmadeira added 2 commits May 13, 2024 13:09
@djmadeira
remove other spec:
b82e4b8 
g

Signed-off-by: djmadeira <[email protected]>
@djmadeira
oops
1b2ed6d 
Signed-off-by: djmadeira <[email protected]>
@djmadeira
Copy link
Contributor Author

@nhtruong looks like I got some wires crossed between the two PRs. fixed now.

@github-actions GitHub Actions
Copy link
Contributor

API specs implemented for 307/649 (47%) APIs.

@djmadeira djmadeira requested a review from dblock May 13, 2024 21:06
@nhtruong nhtruong dismissed dblock’s stale review May 13, 2024 22:36

This has already been resolved

@nhtruong nhtruong merged commit deeb400 into opensearch-project:main May 13, 2024
5 checks passed
@djmadeira djmadeira mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhtruong nhtruong nhtruong approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@pgtgrly pgtgrly Awaiting requested review from pgtgrly

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djmadeira @dblock @nhtruong