Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing pluralization on Role #153

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Fix missing pluralization on Role #153

merged 4 commits into from
Oct 2, 2023

Conversation

jgillich
Copy link
Contributor

@jgillich jgillich commented Oct 1, 2023

Description

Both cluster_permission and index_permission should be plural as per the docs.

Xtansia
Xtansia previously approved these changes Oct 1, 2023
View reviewed changes
Xtansia
Xtansia requested changes Oct 1, 2023
View reviewed changes
Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @jgillich, with your latest fix for being a list, I looked a bit closer, and noticed a couple other discrepancies that'd be awesome if you could fix while you're in this area?

model/security/role.smithy Show resolved Hide resolved
model/security/role.smithy Outdated Show resolved Hide resolved
@jgillich
Copy link
Contributor Author

jgillich commented Oct 2, 2023

Sure thing @Xtansia, I hope I did everything correctly 😄

Xtansia
Xtansia approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@VachaShah VachaShah merged commit 7cded7c into opensearch-project:main Oct 2, 2023
4 checks passed
@jgillich jgillich deleted the patch-1 branch October 2, 2023 00:20
@jgillich jgillich mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@Xtansia Xtansia Xtansia approved these changes

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@pgtgrly pgtgrly Awaiting requested review from pgtgrly

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgillich @Xtansia @VachaShah