Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][TEST-FRAMEWORK] Version selector not handling patch version correctly #500

Closed
nhtruong opened this issue Aug 12, 2024 · 2 comments · Fixed by #501
Closed

[BUG][TEST-FRAMEWORK] Version selector not handling patch version correctly #500

nhtruong opened this issue Aug 12, 2024 · 2 comments · Fixed by #501
Assignees
@dblock
Labels
bug Something isn't working

Comments

@nhtruong
Copy link
Collaborator

A test story was skipped because:

Skipped because version 2.17.0 does not satisfy >= 2.11, < 3.0.

This is most likely due to 2.17.0 was used instead of 2.17.
@nhtruong nhtruong added bug Something isn't working untriaged and removed untriaged labels Aug 12, 2024
@nhtruong nhtruong mentioned this issue Aug 12, 2024
Merged
@dblock
Copy link
Member

dblock commented Aug 12, 2024

I'll take it.

@dblock dblock self-assigned this Aug 12, 2024
@dblock
Copy link
Member

dblock commented Aug 12, 2024 •
edited
Loading

Looks like I already fixed it here but I'll refactor it with explicit tests. The issue is that we don't properly support ranges.

@dblock dblock mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblock dblock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: semver comparisons for ranges. dblock/opensearch-api-specification
2 participants
@dblock @nhtruong