Skip to content

Commit

Permalink
# skipped -> has_errors
Browse files Browse the repository at this point in the history
Signed-off-by: Theo Truong <[email protected]>
  • Loading branch information
nhtruong committed May 28, 2024
1 parent 836cd18 commit 5edf57a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/src/tester/StoryEvaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default class StoryEvaluator {
story: Story
display_path: string
full_path: string
skipped: boolean = false
has_errors: boolean = false
result: Result = Result.PASSED
chapter_reader: ChapterReader

Expand Down Expand Up @@ -48,8 +48,8 @@ export default class StoryEvaluator {
}

async #evaluate_chapters (chapters: Chapter[]): Promise<ChapterEvaluation[]> {
let skipped: boolean = this.skipped
if (skipped) return []
if (this.has_errors) return []
let skipped: boolean = this.has_errors

const evaluations: ChapterEvaluation[] = []

Expand All @@ -75,7 +75,7 @@ export default class StoryEvaluator {
} catch (error) {
if (!(error instanceof ResponseError)) throw error
this.result = Result.ERROR
this.skipped = true
this.has_errors = true
evaluations.push({ title, result: Result.ERROR, message: (error).message })
}
}
Expand Down

0 comments on commit 5edf57a

Please sign in to comment.