-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates sample cert and admin keystore #1806
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
should be merged post opensearch-project/security#4061 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarshitChanpura can you leave some comments as to why this change is needed? Is CI failing somewhere? Can you provide a mechanism to pull these in via security plugin? I have seen you made PRs in all repos before and it feels like its better to pull it from one place and not hard code them everywhere
Downstream change coming from security plugin: opensearch-project/security#4061
This is left onto maintainers to refactor build.gradle to pull artifacts from security repository. Refer to k-NN's build.gradle. These certificates should not be hardcoded in individual plugin repos instead they should be pulled from security-plugin as needed. Even better solution would be to generate own certificates and setup the configuration as required, thus avoiding any dependency on security plugin's certificates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the block but not approving until upstream change is merged and CI is green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Hello reviewers, This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0. Thanks! |
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 11aa920) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 11aa920) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 11aa920) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 11aa920) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Downstream change coming from security plugin: opensearch-project/security#4061
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.