Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates sample cert and admin keystore #1806

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

DarshitChanpura
Copy link
Member

Description

Downstream change coming from security plugin: opensearch-project/security#4061

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura
Copy link
Member Author

should be merged post opensearch-project/security#4061 is merged

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarshitChanpura can you leave some comments as to why this change is needed? Is CI failing somewhere? Can you provide a mechanism to pull these in via security plugin? I have seen you made PRs in all repos before and it feels like its better to pull it from one place and not hard code them everywhere

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 21, 2024

can you leave some comments as to why this change is needed?

Downstream change coming from security plugin: opensearch-project/security#4061
CI will start failing because of certificate mismatch, since the public certificates used are updated, thus sample.pem will not be verifiable since it has old certs

Can you provide a mechanism to pull these in via security plugin?

This is left onto maintainers to refactor build.gradle to pull artifacts from security repository. Refer to k-NN's build.gradle.

These certificates should not be hardcoded in individual plugin repos instead they should be pulled from security-plugin as needed. Even better solution would be to generate own certificates and setup the configuration as required, thus avoiding any dependency on security plugin's certificates.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the block but not approving until upstream change is merged and CI is green

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gaiksaya
Copy link
Member

gaiksaya commented Mar 25, 2024

Hello reviewers,

This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0.
Please review and merge.
Looks like it would need backport to 2.x and 2.13?

Thanks!

@ps48 ps48 merged commit 11aa920 into opensearch-project:main Mar 26, 2024
15 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 11aa920)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 11aa920)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit 11aa920)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit 11aa920)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants