Update index search preference #1595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
derek-ho
reviewed
Aug 28, 2023
| @@ -54,6 +54,7 @@ internal object ObservabilityIndex { | |||
| private const val NOTEBOOKS_INDEX_NAME = ".opensearch-notebooks" | |||
| private const val OBSERVABILITY_MAPPING_FILE_NAME = "observability-mapping.yml" | |||
| private const val OBSERVABILITY_SETTINGS_FILE_NAME = "observability-settings.yml" | |||
| private const val SEARCH_ACTION_PREFERENCE = "_primary" | |||
There was a problem hiding this comment.
Would _primary_first be a better option? https://opensearch.org/docs/latest/api-reference/search/#the-preference-query-parameter
derek-ho
approved these changes
Aug 28, 2023
|
@ps48 this should be backported to 2.x as well, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update index search preference to
_primaryIssues Resolved
#1562
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.