Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up version 1.2 #360

Closed

Conversation

Tengda-He
Copy link
Contributor

Description

Updates notificationsDashboards version to 1.2. Changes the package jsons, as well as the github action workflows.

Issues Related

#332

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #360 (12a4a4f) into main (416b099) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   83.02%   83.75%   +0.73%     
==========================================
  Files          66       66              
  Lines        1867     1884      +17     
  Branches      487      495       +8     
==========================================
+ Hits         1550     1578      +28     
+ Misses        310      299      -11     
  Partials        7        7              
Flag Coverage Δ
dashboards-notifications 83.75% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/NotificationsTable/Flyout/ChannelCard.tsx 92.85% <0.00%> (-7.15%) ⬇️
...tions/public/pages/Emails/CreateRecipientGroup.tsx 81.81% <0.00%> (-1.52%) ⬇️
...-notifications/public/pages/Emails/utils/helper.ts 95.65% <0.00%> (ø)
...cations/public/pages/CreateChannel/utils/helper.ts 100.00% <0.00%> (ø)
...c/pages/Notifications/containers/Notifications.tsx 55.71% <0.00%> (ø)
...CreateChannel/components/CustomWebhookSettings.tsx 82.60% <0.00%> (ø)
.../Emails/components/tables/RecipientGroupsTable.tsx 82.00% <0.00%> (+0.36%) ⬆️
...nels/components/details/ChannelSettingsDetails.tsx 84.78% <0.00%> (+0.69%) ⬆️
...ions/public/pages/Emails/utils/validationHelper.ts 93.47% <0.00%> (+1.58%) ⬆️
...tions/public/pages/CreateChannel/CreateChannel.tsx 88.23% <0.00%> (+3.49%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416b099...12a4a4f. Read the comment docs.

@Tengda-He Tengda-He force-pushed the bump-up-version-1.2 branch 2 times, most recently from 32bacca to 12a4a4f Compare November 2, 2021 20:04
…sons, as well as the github action workflows.

Signed-off-by: Tengda He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants