Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added Reranker feature (#591) #592

Conversation

martin-gaievski
Copy link
Member

Manual backport 1bb48e2 from 591

* Adding support for generic re-ranker interface and opensearch ml re-ranker for improving search relavancy. (opensearch-project#494)

Signed-off-by: HenryL27 <[email protected]>
Co-authored-by: Heemin Kim <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>

---------

Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Co-authored-by: HenryL27 <[email protected]>
Co-authored-by: Heemin Kim <[email protected]>
(cherry picked from commit 1bb48e2)
Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski force-pushed the backport/backport-591-to-2.x branch from 0c5f387 to 8c9f719 Compare February 6, 2024 02:44
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (ac04063) 85.24% compared to head (8c9f719) 85.17%.

Files Patch % Lines
...ssor/rerank/context/QueryContextSourceFetcher.java 77.77% 8 Missing and 4 partials ⚠️
...arch/processor/factory/RerankProcessorFactory.java 75.00% 4 Missing and 4 partials ⚠️
...rch/processor/rerank/RescoringRerankProcessor.java 84.09% 5 Missing and 2 partials ⚠️
...g/opensearch/neuralsearch/plugin/NeuralSearch.java 0.00% 6 Missing ⚠️
...neuralsearch/processor/rerank/RerankProcessor.java 80.00% 4 Missing ⚠️
...arch/neuralsearch/processor/rerank/RerankType.java 86.66% 1 Missing and 1 partial ⚠️
...r/rerank/context/DocumentContextSourceFetcher.java 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #592      +/-   ##
============================================
- Coverage     85.24%   85.17%   -0.08%     
- Complexity      543      611      +68     
============================================
  Files            40       48       +8     
  Lines          1586     1841     +255     
  Branches        249      279      +30     
============================================
+ Hits           1352     1568     +216     
- Misses          117      145      +28     
- Partials        117      128      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski merged commit d95ee65 into opensearch-project:2.x Feb 6, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants