-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x Distribution bundle bwc tests #574
2.x Distribution bundle bwc tests #574
Conversation
Signed-off-by: Varun Jain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #574 +/- ##
=========================================
Coverage 85.24% 85.24%
Complexity 543 543
=========================================
Files 40 40
Lines 1586 1586
Branches 249 249
=========================================
Hits 1352 1352
Misses 117 117
Partials 117 117 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking in sample credentials, can we just pull them like we do for our security enabled tests? I prefer to avoid checking in credentials - its hard to maintain. https://github.com/opensearch-project/neural-search/blob/main/build.gradle#L95-L103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually looks good to me. Have you tried to run locally with the bundle BWC tests? @vibrantvarun
@zelinh yes I did |
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun can you please post results of local run here? |
Signed-off-by: Varun Jain <[email protected]>
|
Closing this as I have raised the PR on main #579. Then backport it on 2.x to maintain consistency within branches. |
Description
There is a framework for BWC tests on distribution level as well which will set up the test cluster with the bundle distribution including all plugins engineering effectiveness team builds.
It will be beneficial during the release cycle since we will be testing the exact distribution that we would ship to the customers.
This PR consist configuration to run bwc tests on distribution bundle. The PR is on Branch 2.x
The bwc distribution will fail on neural search for opensearch versions <2.11 because of the bug from the ml-commons.
opensearch-project/ml-commons#1838
Issues Resolved
564
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.