Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to admin:admin #551

Merged
merged 12 commits into from
Jan 26, 2024
Merged

Remove references to admin:admin #551

merged 12 commits into from
Jan 26, 2024

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Jan 23, 2024 •
edited
Loading

Description

Remove default password of admin. Recently, security repo has mandated that there will no admin:admin password from 2.12. Therefore, removing default admin password from developer guide in this PR.

Issues

Part of opensearch-project/security#3624
Resolves:
#550

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun
Remove admin credentials
aa6b710 
Signed-off-by: Varun Jain <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dadf25) 84.39% compared to head (b0fa08b) 84.39%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #551   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity      535      535           
=========================================
  Files            40       40           
  Lines          1570     1570           
  Branches        245      245           
=========================================
  Hits           1325     1325           
  Misses          133      133           
  Partials        112      112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vibrantvarun
Setting password
b66f263 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun vibrantvarun marked this pull request as ready for review January 23, 2024 20:42
@vibrantvarun
Copy link
Member Author

The security tests are expected to fail as the support for custom password is enabled from 2.12

DarshitChanpura
DarshitChanpura suggested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vibrantvarun ty for this PR. I've suggested a change I think is needed to fetch the correct password.

build.gradle Outdated Show resolved Hide resolved
@DarshitChanpura DarshitChanpura mentioned this pull request Jan 23, 2024
Closed
2 tasks
DarshitChanpura
DarshitChanpura reviewed Jan 23, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@vibrantvarun
Adding version check
f8ee1a6 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun
Adding version check
bbc7633 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun vibrantvarun self-assigned this Jan 24, 2024
DarshitChanpura
DarshitChanpura reviewed Jan 24, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@DarshitChanpura
Copy link
Member

DarshitChanpura commented Jan 24, 2024 •
edited
Loading

This PR is not needed since the neural-search integTest task doesn't use install_demo_configuration.sh to setup the cluster. Instead it installs the plugin and sets the opensearch security configuration manually. Closing this PR now. Feel free to re-open if I missed something.
For more details refer the comments: opensearch-project/flow-framework#310

@vibrantvarun vibrantvarun mentioned this pull request Jan 24, 2024
Closed
2 tasks
@ryanbogan ryanbogan mentioned this pull request Jan 25, 2024
Merged
5 tasks
@DarshitChanpura
Copy link
Member

DarshitChanpura commented Jan 25, 2024 •
edited
Loading

Re-opening to update DEVELOPER_GUIDE.md. No changes to build.gradle are required. @vibrantvarun Thoughts?

DarshitChanpura
DarshitChanpura reviewed Jan 26, 2024
View reviewed changes
DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
@vibrantvarun
Addressing Darshit Comment
b0fa08b 
Signed-off-by: Varun Jain <[email protected]>
DarshitChanpura
DarshitChanpura approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vibrantvarun vibrantvarun added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jan 26, 2024
@junqiu-lei junqiu-lei merged commit f9937a4 into opensearch-project:main Jan 26, 2024
72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2024
@vibrantvarun @github-actions
Remove references to admin:admin (#551)
ea1be68 
Remove references to admin:admin (#551)

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit f9937a4)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 26, 2024
Merged
heemin32 pushed a commit that referenced this pull request Jan 26, 2024
@opensearch-trigger-bot @vibrantvarun
Remove references to admin:admin (#551) (#561)
4db13d1 
Remove references to admin:admin (#551)

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit f9937a4)

Co-authored-by: Varun Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@DarshitChanpura DarshitChanpura DarshitChanpura approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn

@jngz-es jngz-es Awaiting requested review from jngz-es

Assignees

@vibrantvarun vibrantvarun

Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vibrantvarun @DarshitChanpura @junqiu-lei @martin-gaievski