Run Integ test in a secure opensearch cluster #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=========================================
Coverage 84.33% 84.33%
Complexity 533 533
=========================================
Files 40 40
Lines 1564 1564
Branches 244 244
=========================================
Hits 1319 1319
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Jain <[email protected]>
owaiskazi19
reviewed
Jan 13, 2024
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
changed the title
owaiskazi19
reviewed
Jan 16, 2024
owaiskazi19
reviewed
Jan 16, 2024
owaiskazi19
reviewed
Jan 16, 2024
| dependencies { | ||
| classpath "${opensearch_group}.gradle:build-tools:${opensearch_version}" | ||
| classpath "com.diffplug.spotless:spotless-plugin-gradle:6.23.2" | ||
| classpath "io.freefair.gradle:lombok-plugin:8.4" |
There was a problem hiding this comment.
Why adding spotless and lombok again? It's already there in the build.gradle. Looks like a copy/paste issue.
There was a problem hiding this comment.
After removing those 2 lines I get below error. It is because in these two lines adds spotless and lombok with a version in the classpath. And in below lines I just do apply lombok
./gradlew spotlessApply
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* Where:
Build file '/Users/varunudr/neuralsearch/neural-search/build.gradle' line: 56
* What went wrong:
A problem occurred evaluating root project 'neural-search'.
> Plugin with id 'com.diffplug.spotless' not found.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring root project 'neural-search'.
> Failed to notify project evaluation listener.
> Must specify license and notice file for project :
> description is a required setting for opensearchplugin
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
==============================================================================
Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Varun Jain <[email protected]>
Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Varun Jain <[email protected]>
heemin32
approved these changes
Jan 16, 2024
martin-gaievski
approved these changes
Jan 16, 2024
martin-gaievski
added
backport 2.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-535-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6841cc346aabf1f25fe2a33d45fa2cb8ab13e9e
# Push it to GitHub
git push --set-upstream origin backport/backport-535-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
martin-gaievski
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Run Integ test in secure opensearch cluster Signed-off-by: Varun Jain <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds a github workflow test-security.yml which consists actions to run integ tests in secure opensearch cluster.
Issues Resolved
#201
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.