Enhance: Add comments to chunking-related code #1106
Merged
+90
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws and
minalsha
as code owners
yuye-aws
added
backport 2.x
Signed-off-by: yuye-aws <[email protected]>
|
Pinging @vibrantvarun for review. |
|
Will review it in sometime. |
zhichao-aws
approved these changes
Jan 15, 2025
vibrantvarun
approved these changes
Jan 16, 2025
|
Thank @yuye-aws for raising this PR. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
* add logs for chunker parameter parser Signed-off-by: yuye-aws <[email protected]> * add logs for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * add comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> * add comments for chunker facdtory Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 3130de3)
zhichao-aws
pushed a commit
that referenced
this pull request
Jan 16, 2025
* add logs for chunker parameter parser Signed-off-by: yuye-aws <[email protected]> * add logs for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * add comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> * add comments for chunker facdtory Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 3130de3) Co-authored-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the warning messages in the build logs.
Related Issues
1105
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.