-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of new k-NN query parameter, expand_nested #1013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
src/main/java/org/opensearch/neuralsearch/query/NeuralQueryBuilder.java
Outdated
Show resolved
Hide resolved
Please resolve the changelog conflict |
|
Overall code looks good to me. |
I'd like to create a new issue for it. - #1025 |
qa/restart-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/HybridSearchIT.java
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/HybridSearchIT.java
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/HybridSearchIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bo Zhang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
============================================
+ Coverage 78.55% 78.72% +0.16%
- Complexity 1028 1033 +5
============================================
Files 85 85
Lines 3623 3633 +10
Branches 605 609 +4
============================================
+ Hits 2846 2860 +14
+ Misses 528 525 -3
+ Partials 249 248 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1013-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fba4961e9ec5fe28dabb3b004a1ea82b30d45773
# Push it to GitHub
git push --set-upstream origin backport/backport-1013-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Support new knn query parameter
expand_nested_docs
.Related Issues
Resolves #1008
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.