Extend error message, fix typo in class name

Signed-off-by: Martin Gaievski <[email protected]>
opensearch-project · Dec 29, 2023 · 6e3264d · 6e3264d
1 parent 7d6dc4c
commit 6e3264d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java b/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java
@@ -180,7 +180,12 @@ private SearchHit[] getSearchHits(final List<Integer> docIds, final FetchSearchR
         }
         if (searchHitArray.length != docIds.size()) {
             throw new IllegalStateException(
-                "score normalization processor cannot produce final query result, the number of documents returned by fetch and query phases does not match"
+                String.format(
+                    Locale.ROOT,
+                    "score normalization processor cannot produce final query result, the number of documents after fetch phase [%d] is different from number of documents from query phase [%d]",
+                    searchHitArray.length,
+                    docIds.size()
+                )
             );
         }
         return searchHitArray;

diff --git a/...arch/search/HitsTresholdCheckerTests.java → ...rch/search/HitsThresholdCheckerTests.java b/...arch/search/HitsTresholdCheckerTests.java → ...rch/search/HitsThresholdCheckerTests.java
@@ -10,9 +10,9 @@
 import org.apache.lucene.search.ScoreMode;
 import org.opensearch.neuralsearch.query.OpenSearchQueryTestCase;
 
-public class HitsTresholdCheckerTests extends OpenSearchQueryTestCase {
+public class HitsThresholdCheckerTests extends OpenSearchQueryTestCase {
 
-    public void testTresholdReached_whenIncrementCount_thenTresholdReached() {
+    public void testThresholdReached_whenIncrementCount_thenThresholdReached() {
         HitsThresholdChecker hitsThresholdChecker = new HitsThresholdChecker(5);
         assertEquals(5, hitsThresholdChecker.getTotalHitsThreshold());
         assertEquals(ScoreMode.TOP_SCORES, hitsThresholdChecker.scoreMode());
@@ -23,7 +23,7 @@ public void testTresholdReached_whenIncrementCount_thenTresholdReached() {
         assertTrue(hitsThresholdChecker.isThresholdReached());
     }
 
-    public void testTresholdLimit_whenThresholdNegative_thenFail() {
+    public void testThresholdLimit_whenThresholdNegative_thenFail() {
         expectThrows(IllegalArgumentException.class, () -> new HitsThresholdChecker(-1));
     }