Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Filter out remote model auto redeployment (#2976)" and related commits (#3104, #3241) #3368

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jan 10, 2025

Description

Revert "Filter out remote model auto redeployment (#2976)" and related commits (#3104, #3241)

Remote models not auto redeploying after cluster restart had been causing issues with model status changing to DEPLOY_FAILED and PARTIALLY_DEPLOYED. Hence reverting the above mentioned commits

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rbhavna rbhavna force-pushed the revert_auto_redeploy branch from 447f0b4 to b145834 Compare January 10, 2025 19:47
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:48 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:48 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:48 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:48 — with GitHub Actions Inactive
@rbhavna rbhavna force-pushed the revert_auto_redeploy branch from 16b0c89 to e740eb3 Compare January 10, 2025 19:49
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:50 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 19:50 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 10, 2025 20:48 — with GitHub Actions Inactive
@rbhavna rbhavna requested a review from mingshl as a code owner January 11, 2025 01:44
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 11, 2025 01:44 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 11, 2025 01:44 — with GitHub Actions Failure
@rbhavna rbhavna force-pushed the revert_auto_redeploy branch from 1bd8cce to a3371fe Compare January 11, 2025 02:02
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 11, 2025 02:02 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 11, 2025 02:02 — with GitHub Actions Inactive
@rbhavna rbhavna merged commit 7e8b253 into opensearch-project:main Jan 11, 2025
6 checks passed
@rbhavna rbhavna changed the title Revert "Filter out remote model auto redeployment (#2976)" and related commits (#3104, #3214) Revert "Filter out remote model auto redeployment (#2976)" and related commits (#3104, #3241) Jan 11, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3368-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e8b253eadfd60b7d1ec8e2183fca8e488f914ae
# Push it to GitHub
git push --set-upstream origin backport/backport-3368-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3368-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-3368-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e8b253eadfd60b7d1ec8e2183fca8e488f914ae
# Push it to GitHub
git push --set-upstream origin backport/backport-3368-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-3368-to-2.17.

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 11, 2025 03:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants