Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException (unrecognized parameters) error when running /_plugins/_ml/models/{model_id}/{version}/_register #3293

Conversation

nathaliellenaa
Copy link

Description

Added a failing unit test to demonstrate path parameter consumption issue in RestMLRegisterModelAction.

Related Issues

Fix for #3292

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

Apply Spotless

@nathaliellenaa
Copy link
Author

The /_plugins/_ml/models/{model_id}/{version}/_register API doesn't work in previous versions. Therefore, both APIs (/_plugins/_ml/models/{model_id}/{version}/_register and /_plugins/_ml/models/{model_id}/{version}/_upload ref) can be deprecated and this PR can be closed. The cx now are only using /_plugins/_ml/models/_register to register a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants