[Backport 2.x] [Enhancement] Enhance validation for create connector API #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> (cherry picked from commit 58903ba)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
mingshl
approved these changes
Dec 17, 2024
|
Hi @akolarkunnu in ConnectorActionTest.java, there is unused imported in 2.x branch, can you clone this branch and apply the new commit to fix it? backport/backport-3260-to-2.x |
ok, I will check. |
@mingshl There is no any unused imports. But it is complaining about String Blocks(line number 103). String Blocks are introduced in JDK15. And this project(ml-commons 2.x branch) is based on JDK17. So it should not complain. Or Am I missing anything? |
|
@akolarkunnu try checking the Spotless configuration in the build file to ensure it's set up correctly for Java 17. And check if the project's build configuration in build.gradle is correctly set to use Java 17. |
dhrubo-os
reviewed
Dec 24, 2024
|
|
||
| XContentBuilder builder = XContentBuilder.builder(XContentType.JSON.xContent()); | ||
| action.toXContent(builder, ToXContent.EMPTY_PARAMS); | ||
| String content = TestHelper.xContentBuilderToString(builder); | ||
| Assert.assertEquals("{\"action_type\":\"PREDICT\",\"method\":\"http\",\"url\":\"https://test.com\"}", content); | ||
| String expctedContent = """ |
There was a problem hiding this comment.
This doesn't support in Java 17. In main branch, we use JAVA 21 which support this string. So for you I would suggest to do:
- Fix main branch code with not using
""" - And then backport both of the commits together in 2.x branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 58903ba from #3260