Enhance Message and Memory API Validation and storage #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithin-pullela-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
rithin-pullela-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
rithin-pullela-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Skip saving empty fields in interactions and conversations to optimize storage usage. Modify GET requests for interactions and conversations to return only non-null fields. Throw an exception if all fields in a create interaction call are empty or null. Add unit tests to cover the above cases. Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
force-pushed
the
memAPi-validations
branch
from
abba594 to
c0ac084
Compare
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
mingshl
reviewed
Dec 17, 2024
common/src/test/java/org/opensearch/ml/common/conversation/InteractionTests.java
Show resolved
Hide resolved
memory/src/main/java/org/opensearch/ml/memory/index/ConversationMetaIndex.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Dec 17, 2024
...ry/src/main/java/org/opensearch/ml/memory/action/conversation/CreateConversationRequest.java
Show resolved
Hide resolved
dhrubo-os
reviewed
Dec 17, 2024
...c/test/java/org/opensearch/ml/memory/action/conversation/CreateConversationRequestTests.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Dec 17, 2024
...rc/test/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequestTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: rithin-pullela-aws <[email protected]>
Used assertThrows and added promptTemplate with empty string in test_ToXContent to ensure well rounded testing of expected functionality Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
pyek-bot
reviewed
Dec 18, 2024
memory/src/main/java/org/opensearch/ml/memory/index/InteractionsIndex.java
Outdated
Show resolved
Hide resolved
pyek-bot
reviewed
Dec 18, 2024
...c/test/java/org/opensearch/ml/memory/action/conversation/CreateConversationRequestTests.java
Outdated
Show resolved
Hide resolved
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
…rsation or CreateInteraction. Signed-off-by: rithin-pullela-aws <[email protected]>
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
reviewed
Dec 24, 2024
memory/src/main/java/org/opensearch/ml/memory/action/conversation/CreateInteractionRequest.java
Show resolved
Hide resolved
dhrubo-os
approved these changes
Dec 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
* Enchance Message and Memory API Validation and storage Throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Skip saving empty fields in interactions and conversations to optimize storage usage. Modify GET requests for interactions and conversations to return only non-null fields. Throw an exception if all fields in a create interaction call are empty or null. Add unit tests to cover the above cases. Signed-off-by: rithin-pullela-aws <[email protected]> * Update unit test to check for null instead of empty map Signed-off-by: rithin-pullela-aws <[email protected]> * Refactored userstr to Camel Case Signed-off-by: rithin-pullela-aws <[email protected]> * Addressing comments Used assertThrows and added promptTemplate with empty string in test_ToXContent to ensure well rounded testing of expected functionality Signed-off-by: rithin-pullela-aws <[email protected]> * Undo: throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> (cherry picked from commit 06d39b9)
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 25, 2024
…ject#3283) * Enchance Message and Memory API Validation and storage Throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Skip saving empty fields in interactions and conversations to optimize storage usage. Modify GET requests for interactions and conversations to return only non-null fields. Throw an exception if all fields in a create interaction call are empty or null. Add unit tests to cover the above cases. Signed-off-by: rithin-pullela-aws <[email protected]> * Update unit test to check for null instead of empty map Signed-off-by: rithin-pullela-aws <[email protected]> * Refactored userstr to Camel Case Signed-off-by: rithin-pullela-aws <[email protected]> * Addressing comments Used assertThrows and added promptTemplate with empty string in test_ToXContent to ensure well rounded testing of expected functionality Signed-off-by: rithin-pullela-aws <[email protected]> * Undo: throw an error when an unknown field is provided in CreateConversation or CreateInteraction. Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip saving empty fields in interactions and conversations to optimize storage usage.
Modify GET requests for interactions and conversations to return only non-null fields.
Throw an exception if all fields in a create interaction call are empty or null.
Add unit tests to cover the above cases.
Description
[Describe what this change achieves]
Related Issues
Resolves #3250
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.