fix for sync up job not working in 2.17 when upgraded from previous versions #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions Signed-off-by: Bhavana Goud Ramaram <[email protected]>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
reviewed
Nov 27, 2024
| @@ -261,6 +261,7 @@ private void queryRunningModels(ActionListener<SearchResponse> listener) { | |||
| private void triggerModelRedeploy(ModelAutoRedeployArrangement modelAutoRedeployArrangement) { | |||
| if (modelAutoRedeployArrangement == null) { | |||
| log.info("No more models in arrangement, skipping the redeployment"); | |||
| redeployAModel(); | |||
There was a problem hiding this comment.
Why should we redeploy the model if modelAutoRedeployArrangement is null?
There was a problem hiding this comment.
This method calls for redeploying the next model. Not the same one. Ideally if this is null, this condition should have been satisfied and triggerModelRedeploy shouldn't be called. Alternatively we can call startCronjobAndClearListener() here as well.
There was a problem hiding this comment.
Please change this to startCronjobAndClearListener method call.
There was a problem hiding this comment.
Also, can you add an else to this if to ensure the cronjob started in edge cases, e.g. user deleted all the models in the index.
ylwu-amzn
previously approved these changes
Dec 3, 2024
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Bhavana Goud Ramaram <[email protected]>
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Dec 12, 2024
Zhangxunmt
approved these changes
Dec 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…ersions (#3241) * fix for sync up job not working in 2.17 when upgraded from previous versions Signed-off-by: Bhavana Goud Ramaram <[email protected]> * add sync-up job in missing places Signed-off-by: Bhavana Goud Ramaram <[email protected]> --------- Signed-off-by: Bhavana Goud Ramaram <[email protected]> (cherry picked from commit c2a40c1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…ersions (#3241) * fix for sync up job not working in 2.17 when upgraded from previous versions Signed-off-by: Bhavana Goud Ramaram <[email protected]> * add sync-up job in missing places Signed-off-by: Bhavana Goud Ramaram <[email protected]> --------- Signed-off-by: Bhavana Goud Ramaram <[email protected]> (cherry picked from commit c2a40c1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…ersions (#3241) * fix for sync up job not working in 2.17 when upgraded from previous versions Signed-off-by: Bhavana Goud Ramaram <[email protected]> * add sync-up job in missing places Signed-off-by: Bhavana Goud Ramaram <[email protected]> --------- Signed-off-by: Bhavana Goud Ramaram <[email protected]> (cherry picked from commit c2a40c1)
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 15, 2024
…ersions (opensearch-project#3241) * fix for sync up job not working in 2.17 when upgraded from previous versions Signed-off-by: Bhavana Goud Ramaram <[email protected]> * add sync-up job in missing places Signed-off-by: Bhavana Goud Ramaram <[email protected]> --------- Signed-off-by: Bhavana Goud Ramaram <[email protected]>
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this pull request
Dec 15, 2024
…ersions (opensearch-project#3241) * fix for sync up job not working in 2.17 when upgraded from previous versions Signed-off-by: Bhavana Goud Ramaram <[email protected]> * add sync-up job in missing places Signed-off-by: Bhavana Goud Ramaram <[email protected]> --------- Signed-off-by: Bhavana Goud Ramaram <[email protected]> Signed-off-by: tkykenmt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for sync up job not working in 2.17 when upgraded from previous versions
Related Issues
Resolves #3238
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.