Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/multi_tenancy] Fix and enable execute remote inference test #3181

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Oct 29, 2024

Description

Fixes and enables a non-working unit test.

  • wrong argument was captured in one case
  • a null (untyped) string wasn't matching anyString(). Mocked the non-null string that should go there.
  • final test compared to CREATED but should be COMPLETED

Related Issues

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env October 29, 2024 02:05 — with GitHub Actions Failure
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env October 29, 2024 02:06 — with GitHub Actions Failure
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env October 29, 2024 14:08 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit ff38d30 into opensearch-project:feature/multi_tenancy Oct 29, 2024
5 of 10 checks passed
@dhrubo-os
Copy link
Collaborator

Thanks for raising this PR.

@dbwiddis dbwiddis deleted the fix-deploy-model-test branch October 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants