-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle to 8.11.1 #3139
Update Gradle to 8.11.1 #3139
Conversation
@dhrubo-os Please add 2.x backport label, thank you! |
Added. |
The last test suite is failing due to:
@reta any suggestion? |
Interesting, I will take a look shortly, thanks @dhrubo-os |
@dhrubo-os seems like an intermittent issue :( |
This doesn't seem like an intermittent issue, as every time I run the test, it kept failing with:
@peterzhuamazon do you have any idea on this? |
You should change your upload artifact action to v4: I dont know if it failing now but try the latest version of both upload and download. |
@dhrubo-os could you please take a look? thanks! |
Thanks @peterzhuamazon I will try this shortly, thanks! |
Signed-off-by: Andriy Redko <[email protected]>
@dhrubo-os apologies, need your approval one more time |
@dhrubo-os good to go? ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution !
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3139-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a987bb9efb95c4dcfd9e775de51515768bfc488
# Push it to GitHub
git push --set-upstream origin backport/backport-3139-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@reta Backport PR is failing. Could you please take a look? |
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5a987bb)
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5a987bb)
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: tkykenmt <[email protected]>
Description
Update Gradle to 8.11.1
Related Issues
N/A
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.