change to model group access for batch job task APIs #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
approved these changes
Oct 11, 2024
Zhangxunmt
reviewed
Oct 11, 2024
| actionListener.onFailure(e); | ||
| }); | ||
| try (ThreadContext.StoredContext threadContext = client.threadPool().getThreadContext().stashContext()) { | ||
| connectorAccessControlHelper |
There was a problem hiding this comment.
Do we need to check connector access control again here? Are model/connector all access controlled through the model group so ideally any role would have the same permission to access both models and connectors?
There was a problem hiding this comment.
I think its fine. batch_predict also only checks for only model access for now. Since predict API is controlled by model access, it makes sense to have it for batch job APIs too. If we are planning to have connector access too, then we should also include it into predict APIs for consistency.
And yes, I don't think connector access is controlled by model group access control. They were designed separately. I think we have to either unify them or remove one of them for remote models. Does not make sense to have both at connector and model level.
Zhangxunmt
approved these changes
Oct 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 12, 2024
* change to model group access for batch job task APIs Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit 6277410)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 12, 2024
* change to model group access for batch job task APIs Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit 6277410)
b4sjoo
pushed a commit
that referenced
this pull request
Oct 12, 2024
* change to model group access for batch job task APIs Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit 6277410) Co-authored-by: Bhavana Ramaram <[email protected]>
b4sjoo
pushed a commit
that referenced
this pull request
Oct 12, 2024
* change to model group access for batch job task APIs Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit 6277410) Co-authored-by: Bhavana Ramaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change access control for batch job task APIs from connector to model group's access control
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.