[Backport 2.11] Bug Fix: Fix for rag processor throwing NPE #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#3089) * [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided (opensearch-project#3066) (opensearch-project#3076) (cherry picked from commit 8b5b38e) Co-authored-by: Pavan Yekbote <[email protected]> * fix: spotless changes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
is the field name also fixed in main and other branches? usually we tried to raise PR in main and backport to earlier versions to make sure it's the same commit all over the places. |
Yes, this has been backported from main. While backporting to 2.11 there are merge conflicts and this PR addresses them. PFA screenshot for merged backports, only this is pending 
|
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
approved these changes
Oct 21, 2024
b4sjoo
approved these changes
Oct 29, 2024
|
Please re-run tests. Failing due to flaky tests. |
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8b5b38e)
Description
Backporting RAG NPE fix to 2.11
Related Issues
Resolves #2983
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.