-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.13] [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
October 8, 2024 17:56
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
October 8, 2024 17:56
Error
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
October 8, 2024 17:56
Error
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
October 8, 2024 17:56
Failure
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 17:57
Inactive
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 17:57
Inactive
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 17:57
Inactive
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 18:46
Inactive
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 18:46
Inactive
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
October 8, 2024 18:46
Inactive
dhrubo-os
approved these changes
Oct 10, 2024
Zhangxunmt
approved these changes
Oct 10, 2024
pyek-bot
added a commit
to pyek-bot/ml-commons
that referenced
this pull request
Oct 10, 2024
…onal parameters are not provided (opensearch-project#3066) (opensearch-project#3076) (cherry picked from commit 8b5b38e) Co-authored-by: Pavan Yekbote <[email protected]>
Zhangxunmt
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided (#3066) (#3076) (cherry picked from commit 8b5b38e) Co-authored-by: Pavan Yekbote <[email protected]> * fix: spotless changes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
pyek-bot
added a commit
to pyek-bot/ml-commons
that referenced
this pull request
Oct 11, 2024
…ch-project#3089) * [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided (opensearch-project#3066) (opensearch-project#3076) (cherry picked from commit 8b5b38e) Co-authored-by: Pavan Yekbote <[email protected]> * fix: spotless changes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
ylwu-amzn
pushed a commit
that referenced
this pull request
Dec 30, 2024
* [Backport 2.12] Bug Fix: Fix for rag processor throwing NPE (#3089) * [Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided (#3066) (#3076) (cherry picked from commit 8b5b38e) Co-authored-by: Pavan Yekbote <[email protected]> * fix: spotless changes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * fix: field names Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8b5b38e from #3066