-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use connector credential in offline batch ingestion #2989
Conversation
Signed-off-by: Xun Zhang <[email protected]>
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 6384ac3)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-2989-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6384ac3a930e63af3b8887fd32d185e499818204
# Push it to GitHub
git push --set-upstream origin backport/backport-2989-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17 Then, create a pull request where the |
@@ -147,6 +156,7 @@ public void writeTo(StreamOutput output) throws IOException { | |||
} else { | |||
output.writeBoolean(false); | |||
} | |||
output.writeOptionalString(connectorId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bwc failure here
@@ -166,6 +176,7 @@ public MLBatchIngestionInput(StreamInput input) throws IOException { | |||
if (input.readBoolean()) { | |||
credential = input.readMap(s -> s.readString(), s -> s.readString()); | |||
} | |||
this.connectorId = input.readOptionalString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 6384ac3) Co-authored-by: Xun Zhang <[email protected]>
…ct#2989) (opensearch-project#3095) Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 6384ac3) Co-authored-by: Xun Zhang <[email protected]>
Description
Use the credential in the connector as an alternative way for auth.
Example:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.