Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK DDB client update and search interface implementation #2590

Merged
merged 3 commits into from
Jun 27, 2024
Merged

SDK DDB client update and search interface implementation #2590

merged 3 commits into from
Jun 27, 2024

Conversation

arjunkumargiri
Copy link
Contributor

Description

SDK DDB client update and search interface implementation.

  • Added implementation of DDB update
  • Search requests are routed to search SDK client
  • Update create and search to write as json attribute instead of a string under source attribute.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:28 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:31 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:31 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 26, 2024 03:31 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri marked this pull request as ready for review June 26, 2024 04:27
dhrubo-os
dhrubo-os reviewed Jun 27, 2024
View reviewed changes
plugin/src/main/java/org/opensearch/ml/sdkclient/DDBOpenSearchClient.java
dynamoDbClient.putItem(putItemRequest);
return new PutDataObjectResponse.Builder().id(id).created(true).build();
} catch (IOException e) {
throw new OpenSearchStatusException("Failed to parse data object " + request.id(), RestStatus.BAD_REQUEST);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if parsing data object is fine, but indexing failed for some other reason may be DDB was not reachable, or throttled or some other reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DDB would through runtime exception which will not be wrapped.

plugin/src/main/java/org/opensearch/ml/sdkclient/util/JsonTransformer.java Outdated
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

@VisibleForTesting
public static Map<String, AttributeValue> convertJsonObjectToItem(JsonNode jsonNode) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convertJsonObjectToDDbAttributeMap? as this method is only taking care of Dynamodb? Same goes for the other method name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the class too? JsonTransformer sounds too generic in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update method name, however would like to keep the name generic to support other json transformation functions in future

@arjunkumargiri
Renamed JsonTransformer method name
a4f465f 
Signed-off-by: Arjun kumar Giri <[email protected]>
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 27, 2024 01:31 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 27, 2024 01:31 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 27, 2024 01:31 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 34fca30 into opensearch-project:feature/multi_tenancy Jun 27, 2024
6 of 9 checks passed
@arjunkumargiri arjunkumargiri deleted the multi_tenancy branch June 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhangxunmt Zhangxunmt Zhangxunmt left review comments

@dbwiddis dbwiddis dbwiddis left review comments

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjunkumargiri @dbwiddis @Zhangxunmt @dhrubo-os