Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector blueprint for Azure OpenAI Embedding and Chat model #1874

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

shengbo-ma
Copy link
Contributor

@shengbo-ma shengbo-ma commented Jan 16, 2024

Description

Add connector blueprint for Azure OpenAI Embedding and Chat model.
PLEASE NOTE the blueprints in this PR contains only self-managed OpenSearch version.

Issues Resolved

#1367

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (433d81b) 82.61% compared to head (420c8f5) 82.61%.

❗ Current head 420c8f5 differs from pull request most recent head cdffa93. Consider uploading reports for the commit cdffa93 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1874      +/-   ##
============================================
- Coverage     82.61%   82.61%   -0.01%     
+ Complexity     5389     5388       -1     
============================================
  Files           521      521              
  Lines         21706    21706              
  Branches       2211     2211              
============================================
- Hits          17933    17932       -1     
- Misses         2873     2876       +3     
+ Partials        900      898       -2     
Flag Coverage Δ
ml-commons 82.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn
Copy link
Collaborator

PLEASE NOTE the blueprints in this PR contains only self-managed OpenSearch version.

Can you also add this note to the blueprint file?

@shengbo-ma
Copy link
Contributor Author

shengbo-ma commented Jan 17, 2024

PLEASE NOTE the blueprints in this PR contains only self-managed OpenSearch version.

Can you also add this note to the blueprint file?

@ylwu-amzn
Since AWS does not provide Azure OpenAI models (embedding or chat), I think my note turns out misleading. The blueprints work regardless of OpenSearch being self-managed or AWS served.
I have removed the note from my PR description.

@ylwu-amzn ylwu-amzn merged commit 671457b into opensearch-project:main Feb 7, 2024
6 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
)

* add: connector blueprint for Azure OpenAI embedding

* add: connector blueprint for azure openai chat model

* minor: fix typo

(cherry picked from commit 671457b)
Zhangxunmt pushed a commit that referenced this pull request Feb 8, 2024
) (#2048)

* add: connector blueprint for Azure OpenAI embedding

* add: connector blueprint for azure openai chat model

* minor: fix typo

(cherry picked from commit 671457b)

Co-authored-by: OysterMax <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2024
)

* add: connector blueprint for Azure OpenAI embedding

* add: connector blueprint for azure openai chat model

* minor: fix typo

(cherry picked from commit 671457b)
ylwu-amzn pushed a commit that referenced this pull request Feb 9, 2024
) (#2062)

* add: connector blueprint for Azure OpenAI embedding

* add: connector blueprint for azure openai chat model

* minor: fix typo

(cherry picked from commit 671457b)

Co-authored-by: OysterMax <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
…ensearch-project#1874)

* add: connector blueprint for Azure OpenAI embedding

* add: connector blueprint for azure openai chat model

* minor: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants