Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CatIndexTool #1746

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add CatIndexTool #1746

merged 2 commits into from
Dec 13, 2023

Conversation

dbwiddis
Copy link
Member

Description

Adds a CatIndexTool for the agent framework.

  • This is an exact copy of the current class on feature/agent_framework_dev branch, except that I removed the getName() and setName() methods which duplicated the Lombok annotations.

Tests pass locally for this module, other failing tests related to memory are unassociated with this PR.

ml-commons git:(cat-index-tool) ./gradlew :opensearch-ml-algorithms:test

BUILD SUCCESSFUL in 1s
11 actionable tasks: 11 up-to-date

Issues Resolved

Fixes #1547 but on main this time.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <[email protected]>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (2761d7d) 82.07% compared to head (cd051f5) 82.05%.

❗ Current head cd051f5 differs from pull request most recent head 4afb1e8. Consider uploading reports for the commit 4afb1e8 to get more accurate results

Files Patch % Lines
...a/org/opensearch/ml/engine/tools/CatIndexTool.java 79.50% 19 Missing and 14 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1746      +/-   ##
============================================
- Coverage     82.07%   82.05%   -0.03%     
- Complexity     4427     4445      +18     
============================================
  Files           425      426       +1     
  Lines         17583    17744     +161     
  Branches       1870     1884      +14     
============================================
+ Hits          14431    14559     +128     
- Misses         2410     2429      +19     
- Partials        742      756      +14     
Flag Coverage Δ
ml-commons 82.05% <79.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Widdis <[email protected]>
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env December 13, 2023 21:35 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env December 13, 2023 21:35 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 48ad895 into opensearch-project:main Dec 13, 2023
6 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 17, 2023
* Add CatIndexTool

Signed-off-by: Daniel Widdis <[email protected]>

* Add test coverage

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 48ad895)
ylwu-amzn pushed a commit that referenced this pull request Dec 18, 2023
* Add CatIndexTool

Signed-off-by: Daniel Widdis <[email protected]>

* Add test coverage

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 48ad895)

Co-authored-by: Daniel Widdis <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
* Add CatIndexTool

Signed-off-by: Daniel Widdis <[email protected]>

* Add test coverage

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Tool development for Cat Index Tool
3 participants