-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory interface in spi #1664
Merged
Merged
Memory interface in spi #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
November 20, 2023 21:06
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 21:06 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 20, 2023 23:08 — with
GitHub Actions
Failure
Hailong-am
reviewed
Nov 21, 2023
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 21:05 — with
GitHub Actions
Failure
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:17 — with
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
============================================
- Coverage 79.67% 79.65% -0.03%
+ Complexity 4020 4016 -4
============================================
Files 394 394
Lines 16385 16379 -6
Branches 1754 1754
============================================
- Hits 13055 13046 -9
- Misses 2654 2657 +3
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:36 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:36 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:37 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:37 — with
GitHub Actions
Error
jngz-es
temporarily deployed
to
ml-commons-cicd-env
November 22, 2023 22:37 — with
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
November 22, 2023 22:37 — with
GitHub Actions
Error
Zhangxunmt
approved these changes
Nov 22, 2023
ylwu-amzn
approved these changes
Nov 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2023
* memory interface Signed-off-by: Jing Zhang <[email protected]> * remove unused test plugin from gradle Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 7cc9399)
ylwu-amzn
pushed a commit
that referenced
this pull request
Dec 18, 2023
* memory interface Signed-off-by: Jing Zhang <[email protected]> * remove unused test plugin from gradle Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 7cc9399) Co-authored-by: Jing Zhang <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
* memory interface Signed-off-by: Jing Zhang <[email protected]> * remove unused test plugin from gradle Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add memory interface in spi.
Issues related
#1614
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.