Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory interface in spi #1664

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Memory interface in spi #1664

merged 2 commits into from
Nov 22, 2023

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Nov 20, 2023

Description

Add memory interface in spi.

Issues related

#1614

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jing Zhang <[email protected]>
spi/build.gradle Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5759bf2) 79.67% compared to head (cc2da26) 79.65%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1664      +/-   ##
============================================
- Coverage     79.67%   79.65%   -0.03%     
+ Complexity     4020     4016       -4     
============================================
  Files           394      394              
  Lines         16385    16379       -6     
  Branches       1754     1754              
============================================
- Hits          13055    13046       -9     
- Misses         2654     2657       +3     
  Partials        676      676              
Flag Coverage Δ
ml-commons 79.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jngz-es jngz-es merged commit 7cc9399 into opensearch-project:main Nov 22, 2023
6 of 12 checks passed
@jngz-es jngz-es deleted the dev branch November 27, 2023 18:50
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 17, 2023
* memory interface

Signed-off-by: Jing Zhang <[email protected]>

* remove unused test plugin from gradle

Signed-off-by: Jing Zhang <[email protected]>

---------

Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 7cc9399)
ylwu-amzn pushed a commit that referenced this pull request Dec 18, 2023
* memory interface

Signed-off-by: Jing Zhang <[email protected]>

* remove unused test plugin from gradle

Signed-off-by: Jing Zhang <[email protected]>

---------

Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 7cc9399)

Co-authored-by: Jing Zhang <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
* memory interface

Signed-off-by: Jing Zhang <[email protected]>

* remove unused test plugin from gradle

Signed-off-by: Jing Zhang <[email protected]>

---------

Signed-off-by: Jing Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants