client factory test coverage

[Arnav-Gr0ver]

Description

[Describe what this change achieves]

Issues Resolved

#1379

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (568bc7e) 79.42% compared to head (4834aaa) 79.51%.
Report is 28 commits behind head on main.

❗ Current head 4834aaa differs from pull request most recent head 46b139c. Consider uploading reports for the commit 46b139c to get more accurate results

Files	Patch %	Lines
...rithms/metrics_correlation/MetricsCorrelation.java	0.00%	46 Missing ⚠️
...pensearch/ml/engine/algorithms/DLModelExecute.java	0.00%	10 Missing ⚠️
.../ml/engine/algorithms/clustering/RCFSummarize.java	78.94%	7 Missing and 1 partial ⚠️
...ain/java/org/opensearch/ml/engine/ModelHelper.java	78.26%	4 Missing and 1 partial ⚠️
..._embedding/HuggingfaceTextEmbeddingTranslator.java	33.33%	4 Missing ⚠️
...gine/algorithms/tokenize/SparseTokenizerModel.java	78.57%	2 Missing and 1 partial ⚠️
...l/engine/algorithms/ad/AnomalyDetectionLibSVM.java	87.50%	0 Missing and 2 partials ⚠️
...thms/anomalylocalization/AnomalyLocalizerImpl.java	96.66%	0 Missing and 2 partials ⚠️
...rics_correlation/MetricsCorrelationTranslator.java	0.00%	2 Missing ⚠️
...ine/algorithms/rcf/FixedInTimeRandomCutForest.java	93.33%	1 Missing and 1 partial ⚠️
... and 12 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1645      +/-   ##
============================================
+ Coverage     79.42%   79.51%   +0.09%     
- Complexity     3982     3987       +5     
============================================
  Files           390      390              
  Lines         16215    16277      +62     
  Branches       1751     1751              
============================================
+ Hits          12879    12943      +64     
+ Misses         2661     2657       -4     
- Partials        675      677       +2     

Flag	Coverage Δ
ml-commons	79.51% <80.51%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jngz-es]

LGTM

[dhrubo-os]

I assume you are adding more tests?

https://app.codecov.io/gh/opensearch-project/ml-commons/pull/1645/blob/ml-algorithms/src/main/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactory.java#L104

Coverage improved, but lot of lines are partially covered. May be we can cover more? Please check, thanks.

[Arnav-Gr0ver]

I assume you are adding more tests?

https://app.codecov.io/gh/opensearch-project/ml-commons/pull/1645/blob/ml-algorithms/src/main/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactory.java#L104

Coverage improved, but lot of lines are partially covered. May be we can cover more? Please check, thanks.

Yeup, I am currently adding more tests and will commit them soon in hopes of covering those partial lines 👍