add new fields in the memory and refactor transport actions #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
reviewed
Nov 12, 2023
| @@ -86,14 +88,20 @@ protected void doExecute(Task task, CreateInteractionRequest request, ActionList | |||
| String rsp = request.getResponse(); | |||
| String ogn = request.getOrigin(); | |||
| String prompt = request.getPromptTemplate(); | |||
| String additionalInfo = request.getAdditionalInfo(); | |||
| Map<String, String> additionalInfo = request.getAdditionalInfo(); | |||
| String parintid = request.getParent_interaction_id(); | |||
plugin/src/main/java/org/opensearch/ml/memory/MLMemoryManager.java
Outdated
Show resolved
Hide resolved
| @@ -171,7 +171,7 @@ public SearchResponse processResponse(SearchRequest request, SearchResponse resp | |||
| PromptUtil.getPromptTemplate(systemPrompt, userInstructions), | |||
| answer, | |||
| GenerativeQAProcessorConstants.RESPONSE_PROCESSOR_TYPE, | |||
| jsonArrayToString(searchResults) | |||
| Collections.singletonMap("metadata", jsonArrayToString(searchResults)) | |||
There was a problem hiding this comment.
can use the key "search_results"?
There was a problem hiding this comment.
Ok let's make it consistent with the previous tests. Will update in the next PR.
Zhangxunmt
force-pushed
the
feature/agent_framework_dev
branch
from
c4729fd to
776cc2b
Compare
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
force-pushed
the
feature/agent_framework_dev
branch
from
776cc2b to
33ffd83
Compare
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
approved these changes
Nov 13, 2023
ylwu-amzn
approved these changes
Nov 13, 2023
Zhangxunmt
merged commit affd351
into
opensearch-project:feature/agent_framework_dev
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new fields in the Memory and refactor the transport actions to support more ML applications.
Issues Resolved
[List any issues this PR will resolve]
Check List
All APIs are working after this change with BWC. The APIs also takes inputs for the new fields.
Some UTs still failing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.