-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase main code to feature branch #1386
Merged
zane-neo
merged 9 commits into
opensearch-project:neural-sparse
from
zane-neo:neural-sparse
Sep 26, 2023
Merged
Rebase main code to feature branch #1386
zane-neo
merged 9 commits into
opensearch-project:neural-sparse
from
zane-neo:neural-sparse
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Auto Release Workflow Signed-off-by: Sicheng Song <[email protected]> * Fix release note address Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]>
…t#1309) Signed-off-by: Sicheng Song <[email protected]>
* Add release note for 2.10.0 Signed-off-by: Sicheng Song <[email protected]> * Add CVE fix Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]>
* fixing doc link Signed-off-by: Dhrubo Saha <[email protected]> * fixing indentation Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]>
…ensearch-project#1324) * Fix unassigned ml system shard replicas * Adjust auto replica settings to keep it consistent with AOS default setting * Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java * Modify exception handling * Modify exception messages * Add response check * Add response check and exception handling * Keep error message consistent * Keep error message consistent * Keep error message consistent --------- Signed-off-by: Sicheng Song <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
…earch-project#1325) Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Kalyan <[email protected]>
…pensearch-project#1274) * Add neural search default pre/post process function support Signed-off-by: zane-neo <[email protected]> * Fix UT failures Signed-off-by: zane-neo <[email protected]> * Address PR comment to remove nonJson response case Signed-off-by: zane-neo <[email protected]> * Fix low code coverage issue Signed-off-by: zane-neo <[email protected]> * fix format issue Signed-off-by: zane-neo <[email protected]> * Try to fix classNotFound issue in IT Signed-off-by: zane-neo <[email protected]> * revert Try to fix classNotFound issue in IT Signed-off-by: zane-neo <[email protected]> * Change gson dependency to compileOnly Signed-off-by: zane-neo <[email protected]> * Change default pre/post process function name Signed-off-by: zane-neo <[email protected]> * Address code review comments Signed-off-by: zane-neo <[email protected]> * Make preprocess function to default Signed-off-by: zane-neo <[email protected]> * Remove GsonUtil since there already a single instance in StringUtils Signed-off-by: zane-neo <[email protected]> * Fix UT failures Signed-off-by: zane-neo <[email protected]> * Address comments Signed-off-by: zane-neo <[email protected]> * use import instead of fully qualified name Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn and
Zhangxunmt
as code owners
September 26, 2023 01:43
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 01:43 — with
GitHub Actions
Inactive
dhrubo-os
approved these changes
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## neural-sparse #1386 +/- ##
===================================================
- Coverage 78.94% 78.72% -0.22%
+ Complexity 2144 2142 -2
===================================================
Files 168 168
Lines 8740 8754 +14
Branches 877 877
===================================================
- Hits 6900 6892 -8
- Misses 1441 1465 +24
+ Partials 399 397 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
approved these changes
Sep 26, 2023
zane-neo
merged commit Sep 26, 2023
8780d1c
into
opensearch-project:neural-sparse
13 of 18 checks passed
model-collapse
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to rebase main branch latest code to feature branch to make sure other PRs to feature branch pass all checks.
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.