-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message in TransportDeplpoyModelAction class #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 24, 2023 04:04 — with
GitHub Actions
Failure
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
September 24, 2023 04:04
dhrubo-os
reviewed
Sep 24, 2023
plugin/src/main/java/org/opensearch/ml/action/deploy/TransportDeployModelAction.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/ml/action/deploy/TransportDeployModelAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
September 26, 2023 18:57 — with
GitHub Actions
Error
Codecov Report
@@ Coverage Diff @@
## main #1368 +/- ##
============================================
+ Coverage 78.73% 78.80% +0.06%
- Complexity 2141 2143 +2
============================================
Files 168 168
Lines 8755 8755
Branches 878 878
============================================
+ Hits 6893 6899 +6
+ Misses 1462 1458 -4
+ Partials 400 398 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dhrubo-os
approved these changes
Sep 26, 2023
ylwu-amzn
approved these changes
Sep 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Fix error message in TransportDeplpoyModelAction class Signed-off-by: Sicheng Song <[email protected]> * Elaborate error message Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit 9b6af2e)
ylwu-amzn
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Fix error message in TransportDeplpoyModelAction class Signed-off-by: Sicheng Song <[email protected]> * Elaborate error message Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> (cherry picked from commit 9b6af2e) Co-authored-by: Sicheng Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the wrong error message in TransportDeplpoyModelAction class
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.