Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in TransportDeplpoyModelAction class #1368

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Sep 24, 2023

Description

This PR fix the wrong error message in TransportDeplpoyModelAction class

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 24, 2023 04:04 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 24, 2023 04:04 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env September 24, 2023 04:04 — with GitHub Actions Failure
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env September 24, 2023 04:04 — with GitHub Actions Failure
@b4sjoo b4sjoo marked this pull request as ready for review September 24, 2023 04:04
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 26, 2023 18:57 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 26, 2023 18:57 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env September 26, 2023 18:57 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 26, 2023 18:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1368 (96b6c46) into main (ad078ff) will increase coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1368      +/-   ##
============================================
+ Coverage     78.73%   78.80%   +0.06%     
- Complexity     2141     2143       +2     
============================================
  Files           168      168              
  Lines          8755     8755              
  Branches        878      878              
============================================
+ Hits           6893     6899       +6     
+ Misses         1462     1458       -4     
+ Partials        400      398       -2     
Flag Coverage Δ
ml-commons 78.80% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...h/ml/action/deploy/TransportDeployModelAction.java 82.73% <100.00%> (ø)

... and 2 files with indirect coverage changes

@b4sjoo b4sjoo merged commit 9b6af2e into opensearch-project:main Sep 26, 2023
7 of 10 checks passed
@b4sjoo b4sjoo deleted the main_fixerror branch September 26, 2023 23:35
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2023
* Fix error message in TransportDeplpoyModelAction class

Signed-off-by: Sicheng Song <[email protected]>

* Elaborate error message

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 9b6af2e)
ylwu-amzn pushed a commit that referenced this pull request Sep 27, 2023
* Fix error message in TransportDeplpoyModelAction class

Signed-off-by: Sicheng Song <[email protected]>

* Elaborate error message

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 9b6af2e)

Co-authored-by: Sicheng Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants