removed empty host check, inherently within httpHost object generation (

#1488) Signed-off-by: Arnav Grover <[email protected]>
opensearch-project · Nov 5, 2023 · 06c0cc5 · 06c0cc5
1 parent 510f50b
commit 06c0cc5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/ml-algorithms/src/main/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactory.java b/ml-algorithms/src/main/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactory.java
@@ -57,10 +57,6 @@ public boolean isRedirected(HttpRequest request, HttpResponse response, HttpCont
 
     @VisibleForTesting
     protected static void validateSchemaAndPort(HttpHost host) {
-        if (Strings.isBlank(host.getHostName())) {
-            log.error("Remote inference host name is empty!");
-            throw new IllegalArgumentException("Host name is empty!");
-        }
         String scheme = host.getSchemeName();
         if ("http".equalsIgnoreCase(scheme) || "https".equalsIgnoreCase(scheme)) {
             String[] hostNamePort = host.getHostName().split(":");

diff --git a/...lgorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java b/...lgorithms/src/test/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactoryTests.java
@@ -102,5 +102,4 @@ public void test_validateSchemaAndPort_portNotInRange_throwException() {
         HttpHost httpHost = new HttpHost("api.openai.com:65537", -1, "https");
         MLHttpClientFactory.validateSchemaAndPort(httpHost);
     }
-
 }
-Original file line number
+Diff line change
@@ Expand Up @@
             HttpHost httpHost = new HttpHost("api.openai.com:65537", -1, "https");
             MLHttpClientFactory.validateSchemaAndPort(httpHost);
         }
     }